Skip to content

fixed typos in tags embed. #3011

Merged
hedyhli merged 1 commit into
python-discord:mainfrom
Hashed0719:main
Apr 13, 2024
Merged

fixed typos in tags embed. #3011
hedyhli merged 1 commit into
python-discord:mainfrom
Hashed0719:main

Conversation

@Hashed0719
Copy link
Copy Markdown
Contributor

Fixed typos discussed in #2583. Removed unnecessary merge commit in previous(closed) PR #3001 .

@Hashed0719 Hashed0719 requested a review from mbaruh as a code owner April 12, 2024 13:44
@Hashed0719
Copy link
Copy Markdown
Contributor Author

ok it seems like i can't really open two different PRs from same branch, the changes are referential until its merged, do i need to create branches locally for that ?

@Hashed0719
Copy link
Copy Markdown
Contributor Author

@GriceTurrble sorry for inconvenience but would you be able to reverify the changes if a rebase and recommit in this PR only or do i have to open a new one ?

@GriceTurrble
Copy link
Copy Markdown

@GriceTurrble sorry for inconvenience but would you be able to reverify the changes if a rebase and recommit in this PR only or do i have to open a new one ?

Either way, I suppose?

@Hashed0719
Copy link
Copy Markdown
Contributor Author

@GriceTurrble done.

@Hashed0719
Copy link
Copy Markdown
Contributor Author

Again sorry for the inconvenience.

Copy link
Copy Markdown
Contributor

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@hedyhli hedyhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hedyhli hedyhli merged commit 15f4d03 into python-discord:main Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants